Commit 51cd1d8e authored by Dainis Abols's avatar Dainis Abols
Browse files

TPO3 v10 Compatability. Needs file migration on install!

parent be17bdfa
......@@ -9,6 +9,7 @@ use Lu\LuNotices\Domain\Repository\TopicsRepository;
use TYPO3\CMS\Core\Core\Environment;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\DataHandling\DataHandler;
use TYPO3\CMS\Core\Resource\FileRepository;
use TYPO3\CMS\Core\Resource\ResourceFactory;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;
......@@ -208,31 +209,13 @@ class NoticesController extends ActionController
* @return array
private function getFilesByNotice($noticeId)
private function getFilesByNotice($noticeId): array
// Pre-set values
$files = [];
$notice = $this->noticesRepository->findByUid($noticeId);
// Check if files found
if (!empty($notice->getFiles())) {
$noticesFiles = explode(',', $notice->getFiles());
// Removes storage folder name
if (!empty($noticesFiles)) {
foreach ($noticesFiles as $filePath) {
if (!empty($filePath) && file_exists(Environment::getPublicPath().'/'.$filePath)) {
$resourceFactory = ResourceFactory::getInstance();
$filePath = str_replace('fileadmin/', '', $filePath);
$f = $resourceFactory->getFileObjectByStorageAndIdentifier(1, $filePath);
$files[] = $f;
$noticesTable = 'tx_lunotices_domain_model_notices';
$fileRepository = GeneralUtility::makeInstance(FileRepository::class);
return $files;
return $fileRepository->findByRelation($noticesTable, 'media', $noticeId);
* This file is part of the TYPO3 CMS project.
* It is free software; you can redistribute it and/or modify it under
* the terms of the GNU General Public License, either version 2
* of the License, or any later version.
* For the full copyright and license information, please read the
* LICENSE.txt file that was distributed with this source code.
* The TYPO3 project - inspiring people to share!
namespace Lu\LuNotices\Updates;
use Doctrine\DBAL\DBALException;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Symfony\Component\Console\Output\OutputInterface;
use TYPO3\CMS\Core\Core\Environment;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Database\Query\Expression\ExpressionBuilder;
use TYPO3\CMS\Core\Resource\File;
use TYPO3\CMS\Core\Resource\ResourceStorage;
use TYPO3\CMS\Core\Resource\StorageRepository;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\PathUtility;
use TYPO3\CMS\Install\Updates\ChattyInterface;
use TYPO3\CMS\Install\Updates\DatabaseUpdatedPrerequisite;
use TYPO3\CMS\Install\Updates\UpgradeWizardInterface;
* Upgrade wizard which goes through all files
* and creates sys_file records as well as sys_file_reference records for each hit.
class FileMigrationWizard implements UpgradeWizardInterface, ChattyInterface, LoggerAwareInterface
use LoggerAwareTrait;
* @var OutputInterface
protected $output;
* @var ResourceStorage
protected $storage;
* Table to migrate records from
* @var string
protected $table = 'tx_lunotices_domain_model_notices';
* Table field holding the migration to be
* @var string
protected $fieldToMigrate = 'files';
* target folder after migration
* Relative to fileadmin
* @var string
protected $targetPath = '_migrated/';
* @return string Unique identifier of this updater
public function getIdentifier(): string
return 'noticesFileMigration';
* @return string Title of this updater
public function getTitle(): string
return 'Migrate all LU Notices file relations to sys_file_references';
* @return string Longer description of this updater
public function getDescription(): string
return 'This update wizard goes through all files that are referenced in the'
. ' notices.files field and adds the files to the FAL File Index.'
. ' It also moves the files from uploads/ to the fileadmin/_migrated/ path.';
* @return bool True if there are records to update
public function updateNecessary(): bool
return !empty($this->getRecordsFromTable());
* @return string[] All new fields and tables must exist
public function getPrerequisites(): array
return [
* @param OutputInterface $output
public function setOutput(OutputInterface $output): void
$this->output = $output;
* Performs the configuration update.
* @return bool
public function executeUpdate(): bool
$result = true;
try {
$storages = GeneralUtility::makeInstance(StorageRepository::class)->findAll();
$this->storage = $storages[0];
$records = $this->getRecordsFromTable();
foreach ($records as $record) {
} catch (\Exception $e) {
// If something goes wrong, migrateField() logs an error
$result = false;
return $result;
* Get records from table where the field to migrate is not empty (NOT NULL and != '')
* and also not numeric (which means that it is migrated)
* @return array
* @throws \RuntimeException
protected function getRecordsFromTable()
$connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
$queryBuilder = $connectionPool->getQueryBuilderForTable($this->table);
try {
return $queryBuilder
->select('uid', 'pid', $this->fieldToMigrate)
$queryBuilder->createNamedParameter('', \PDO::PARAM_STR)
'CAST(CAST(' . $queryBuilder->quoteIdentifier($this->fieldToMigrate) . ' AS DECIMAL) AS CHAR)',
'CAST(' . $queryBuilder->quoteIdentifier($this->fieldToMigrate) . ' AS CHAR)'
} catch (DBALException $e) {
throw new \RuntimeException(
'Database query failed. Error was: ' . $e->getPrevious()->getMessage(),
* Migrates a single field.
* @param array $row
* @throws \Exception
protected function migrateField($row)
$fieldItems = GeneralUtility::trimExplode(',', $row[$this->fieldToMigrate], true);
if (empty($fieldItems) || is_numeric($row[$this->fieldToMigrate])) {
$fileadminDirectory = rtrim($GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'], '/') . '/';
$i = 0;
$storageUid = (int)$this->storage->getUid();
$connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
foreach ($fieldItems as $item) {
$fileUid = null;
$sourcePath = Environment::getPublicPath() . '/' . $item;
$strippedPath = str_replace("fileadmin/user_upload/", "", $item);
$targetDirectory = Environment::getPublicPath() . '/' . $fileadminDirectory . $this->targetPath;
$targetPath = $targetDirectory . $strippedPath;
// Remove file name
$temp = explode("/", $strippedPath);
$subdir = implode("/", $temp);
$subdir = $targetDirectory . $subdir;
// maybe the file was already moved, so check if the original file still exists
if (file_exists($sourcePath) && !is_dir($sourcePath)) {
if (!is_dir($targetDirectory)) {
// Create subdirectory
if (!is_dir($subdir)) {
// see if the file already exists in the storage
$fileSha1 = sha1_file($sourcePath);
$queryBuilder = $connectionPool->getQueryBuilderForTable('sys_file');
$existingFileRecord = $queryBuilder->select('uid')->from('sys_file')->where(
$queryBuilder->createNamedParameter($fileSha1, \PDO::PARAM_STR)
$queryBuilder->createNamedParameter($storageUid, \PDO::PARAM_INT)
// the file exists, the file does not have to be moved again
if (is_array($existingFileRecord)) {
$fileUid = $existingFileRecord['uid'];
} else {
// just move the file (no duplicate)
rename($sourcePath, $targetPath);
if ($fileUid === null) {
// get the File object if it hasn't been fetched before
try {
// if the source file does not exist, we should just continue, but leave a message in the docs;
// ideally, the user would be informed after the update as well.
/** @var File $file */
$file = $this->storage->getFile($this->targetPath . $strippedPath);
$fileUid = $file->getUid();
} catch (\InvalidArgumentException $e) {
// no file found, no reference can be set
'File ' . $item . ' does not exist. Reference was not migrated.',
'table' => $this->table,
'record' => $row,
'field' => $this->fieldToMigrate,
$format = 'File \'%s\' does not exist. Referencing field: %s.%d.%s. The reference was not migrated.';
if ($fileUid > 0) {
$fields = [
'fieldname' => $this->fieldToMigrate,
'table_local' => 'sys_file',
'pid' => $this->table === 'pages' ? $row['uid'] : $row['pid'],
'uid_foreign' => $row['uid'],
'uid_local' => $fileUid,
'tablenames' => $this->table,
'crdate' => time(),
'tstamp' => time(),
'sorting_foreign' => $i,
$queryBuilder = $connectionPool->getQueryBuilderForTable('sys_file_reference');
// Update referencing table's original field to now contain the count of references,
// but only if all new references could be set
if ($i === count($fieldItems)) {
$queryBuilder = $connectionPool->getQueryBuilderForTable($this->table);
$queryBuilder->createNamedParameter($row['uid'], \PDO::PARAM_INT)
)->set($this->fieldToMigrate, $i)->execute();
......@@ -33,6 +33,7 @@ return [
'label' => 'LLL:EXT:lu_notices/Resources/Private/Language/locallang.xlf:starttime',
'config' => [
'type' => 'input',
'renderType' => 'inputDateTime',
'size' => 8,
'max' => 20,
'eval' => 'datetime,int',
......@@ -45,6 +46,7 @@ return [
'label' => 'LLL:EXT:lu_notices/Resources/Private/Language/locallang.xlf:endtime',
'config' => [
'type' => 'input',
'renderType' => 'inputDateTime',
'size' => 8,
'max' => 20,
'eval' => 'datetime,int',
......@@ -86,36 +88,22 @@ return [
'label' => 'LLL:EXT:lu_notices/Resources/Private/Language/locallang.xlf:notices.body',
'config' => [
'type' => 'text',
'enableRichtext' => true,
'cols' => 30,
'rows' => 5,
'eval' => 'trim',
'defaultExtras' => 'richtext[]',
'url' => [
'exclude' => 0,
'label' => 'LLL:EXT:lu_notices/Resources/Private/Language/locallang.xlf:notice.url',
'config' => [
'type' => 'input',
'renderType' => 'inputLink',
'size' => '15',
'max' => '255',
'checkbox' => '',
'eval' => 'trim',
'wizards' => [
'_PADDING' => 2,
'link' => [
'type' => 'popup',
'title' => 'Link',
'icon' => 'link_popup.gif',
'module' => [
'name' => 'wizard_element_browser',
'urlParameters' => [
'mode' => 'wizard',
'JSopenParams' => 'height=300,width=500,status=0,menubar=0,scrollbars=1',
'priority' => [
......@@ -137,18 +125,15 @@ return [
'files' => [
'exclude' => 0,
'label' => 'LLL:EXT:lu_notices/Resources/Private/Language/locallang.xlf:notice.files',
'config' => [
'type' => 'group',
//'internal_type' => 'file',
'internal_type' => 'file_reference',
'allowed' => '',
'disallowed' => 'php,php3',
'max_size' => $GLOBALS['TYPO3_CONF_VARS']['BE']['maxFileSize'],
//'uploadfolder' => 'uploads/user_lunotices',
'size' => 10,
'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
'minitems' => 0,
'maxitems' => 100,
'types' => [
......@@ -91,6 +91,7 @@ return [
'label' => 'LLL:EXT:lu_notices/Resources/Private/Language/locallang.xlf:fegroup',
'config' => [
'type' => 'select',
'renderType' => 'selectSingle',
'foreign_table' => 'fe_groups',
'foreign_table_where' => 'ORDER BY fe_groups.title ASC',
'eval' => 'required',
......@@ -107,7 +108,7 @@ return [
'types' => [
'0' => ['showitem' => 'hidden;;1;;1-1-1, ;;2;;2-2-2, description;;;;3-3-3, priority'],
'0' => ['showitem' => 'hidden, --palette--;;1;;1-1-1, --palette--;;2;;2-2-2, description;;;;3-3-3, priority'],
'palettes' => [
'1' => ['showitem' => 'starttime, endtime, fe_group'],
Version 3, 29 June 2007
Copyright (C) 2007 Free Software Foundation, Inc. <>
Everyone is permitted to copy and distribute verbatim copies
of this license document, but changing it is not allowed.
The GNU General Public License is a free, copyleft license for
software and other kinds of works.
The licenses for most software and other practical works are designed
to take away your freedom to share and change the works. By contrast,
the GNU General Public License is intended to guarantee your freedom to
share and change all versions of a program--to make sure it remains free
software for all its users. We, the Free Software Foundation, use the
GNU General Public License for most of our software; it applies also to
any other work released this way by its authors. You can apply it to
your programs, too.
When we speak of free software, we are referring to freedom, not
price. Our General Public Licenses are designed to make sure that you
have the freedom to distribute copies of free software (and charge for
them if you wish), that you receive source code or can get it if you
want it, that you can change the software or use pieces of it in new
free programs, and that you know you can do these things.
To protect your rights, we need to prevent others from denying you
these rights or asking you to surrender the rights. Therefore, you have
certain responsibilities if you distribute copies of the software, or if
you modify it: responsibilities to respect the freedom of others.
For example, if you distribute copies of such a program, whether
gratis or for a fee, you must pass on to the recipients the same
freedoms that you received. You must make sure that they, too, receive
or can get the source code. And you must show them these terms so they
know their rights.
Developers that use the GNU GPL protect your rights with two steps:
(1) assert copyright on the software, and (2) offer you this License
giving you legal permission to copy, distribute and/or modify it.
For the developers' and authors' protection, the GPL clearly explains
that there is no warranty for this free software. For both users' and
authors' sake, the GPL requires that modified versions be marked as
changed, so that their problems will not be attributed erroneously to
authors of previous versions.
Some devices are designed to deny users access to install or run
modified versions of the software inside them, although the manufacturer
can do so. This is fundamentally incompatible with the aim of
protecting users' freedom to change the software. The systematic
pattern of such abuse occurs in the area of products for individuals to
use, which is precisely where it is most unacceptable. Therefore, we
have designed this version of the GPL to prohibit the practice for those
products. If such problems arise substantially in other domains, we
stand ready to extend this provision to those domains in future versions
of the GPL, as needed to protect the freedom of users.
Finally, every program is threatened constantly by software patents.
States should not allow patents to restrict development and use of
software on general-purpose computers, but in those that do, we wish to
avoid the special danger that patents applied to a free program could
make it effectively proprietary. To prevent this, the GPL assures that
patents cannot be used to render the program non-free.
The precise terms and conditions for copying, distribution and
modification follow.
0. Definitions.
"This License" refers to version 3 of the GNU General Public License.
"Copyright" also means copyright-like laws that apply to other kinds of
works, such as semiconductor masks.
"The Program" refers to any copyrightable work licensed under this
License. Each licensee is addressed as "you". "Licensees" and
"recipients" may be individuals or organizations.
To "modify" a work means to copy from or adapt all or part of the work
in a fashion requiring copyright permission, other than the making of an
exact copy. The resulting work is called a "modified version" of the
earlier work or a work "based on" the earlier work.
A "covered work" means either the unmodified Program or a work based
on the Program.
To "propagate" a work means to do anything with it that, without
permission, would make you directly or secondarily liable for
infringement under applicable copyright law, except executing it on a
computer or modifying a private copy. Propagation includes copying,
distribution (with or without modification), making available to the
public, and in some countries other activities as well.
To "convey" a work means any kind of propagation that enables other
parties to make or receive copies. Mere interaction with a user through
a computer network, with no transfer of a copy, is not conveying.
An interactive user interface displays "Appropriate Legal Notices"
to the extent that it includes a convenient and prominently visible
feature that (1) displays an appropriate copyright notice, and (2)
tells the user that there is no warranty for the work (except to the
extent that warranties are provided), that licensees may convey the
work under this License, and how to view a copy of this License. If
the interface presents a list of user commands or options, such as a
menu, a prominent item in the list meets this criterion.
1. Source Code.
The "source code" for a work means the preferred form of the work
for making modifications to it. "Object code" means any non-source
form of a work.
A "Standard Interface" means an interface that either is an official
standard defined by a recognized standards body, or, in the case of
interfaces specified for a particular programming language, one that
is widely used among developers working in that language.
The "System Libraries" of an executable work include anything, other
than the work as a whole, that (a) is included in the normal form of
packaging a Major Component, but which is not part of that Major
Component, and (b) serves only to enable use of the work with that
Major Component, or to implement a Standard Interface for which an
implementation is available to the public in source code form. A
"Major Component", in this context, means a major essential component
(kernel, window system, and so on) of the specific operating system
(if any) on which the executable work runs, or a compiler used to
produce the work, or an object code interpreter used to run it.
The "Corresponding Source" for a work in object code form means all
the source code needed to generate, install, and (for an executable
work) run the object code and to modify the work, including scripts to
control those activities. However, it does not include the work's
System Libraries, or general-purpose tools or generally available free
programs which are used unmodified in performing those activities but
which are not part of the work. For example, Corresponding Source
includes interface definition files associated with source files for
the work, and the source code for shared libraries and dynamically
linked subprograms that the work is specifically designed to require,
such as by intimate data communication or control flow between those
subprograms and other parts of the work.
The Corresponding Source need not include anything that users
can regenerate automatically from other parts of the Corresponding
The Corresponding Source for a work in source code form is that
same work.
2. Basic Permissions.
All rights granted under this License are granted for the term of
copyright on the Program, and are irrevocable provided the stated
conditions are met. This License explicitly affirms your unlimited
permission to run the unmodified Program. The output from running a
covered work is covered by this License only if the output, given its